Refactoring: make the type of fullname str instead of Bogus[str] #14435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type Bogus[X] is treated as Any when the code is compiled with mypyc, while it's equivalent to X when only type checking. They are sometimes used when X is not actually the real type of a value, but changing it to the correct type would be complicated. Bogus[str] types are pretty awkward, since we are lying to the type checker and mypyc only sees Any types. An empty fullname is now represented by "" instead of None, so we no longer need a Bogus[str] type. (Various small optimizations, including this, together netted a 6% performance improvement in self check.)
This comment has been minimized.
This comment has been minimized.
|
6%? wow |
These are only the gains from small micro-optimizations where the impact of individual optimizations was hard to measure in isolation, so I measured the impact of a bunch of them together. Other optimizations yielded better results. Currently we are at 40% overall improvement in self check performance since the lowest perf level recorded here: https://github.com/mypyc/mypyc-benchmark-results/blob/master/reports/benchmarks/mypy_self_check.md |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type Bogus[X] is treated as Any when the code is compiled with mypyc, while it's equivalent to X when only type checking. They are sometimes used when X is not actually the real type of a value, but changing it to the correct type would be complicated.
Bogus[str] types are pretty awkward, since we are lying to the type checker and mypyc only sees Any types.
An empty fullname is now represented by "" instead of None, so we no longer need a Bogus[str] type.
This might break some plugins, so we should document this in release notes and the relevant issue that tracks plugin incompatibilities.
(Various small optimizations, including this, together netted a 6% performance improvement in self check.)