Optimize implementation of TypedDict types for **kwds #14316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation copied lots of callable types even when not using the new feature, which was expensive. Now we only generate a copy if a callable actually uses TypedDict types for **kwds. This made self check 7-8% faster (when compiled with -O0). The original implementation was in #13471.
JukkaL
commented
Dec 19, 2022
| @@ -1757,7 +1757,7 @@ def copy_modified( | |||
| from_concatenate: Bogus[bool] = _dummy, | |||
| unpack_kwargs: Bogus[bool] = _dummy, | |||
| ) -> CT: | |||
| return type(self)( | |||
| modified = CallableType( | |||
There was a problem hiding this comment.
Mypyc generated really bad code for type(self)(...).
JukkaL
commented
Dec 19, 2022
| @@ -1976,7 +1979,7 @@ def expand_param_spec( | |||
|
|
|||
| def with_unpacked_kwargs(self) -> NormalizedCallableType: | |||
| if not self.unpack_kwargs: | |||
| return NormalizedCallableType(self.copy_modified()) | |||
| return cast(NormalizedCallableType, self) | |||
There was a problem hiding this comment.
The cast is because of mypyc/mypyc#958.
svalentin
approved these changes
Dec 19, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation copied lots of callable types even when not using
the new feature, which was expensive. Now we only generate a copy if a
callable actually uses TypedDict types for **kwds.
This made self check 7-8% faster (when compiled with -O0).
The original implementation was in #13471.