Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type aliases with fixed-length tuples #14184

Merged
merged 7 commits into from
Nov 25, 2022
Merged

Fix type aliases with fixed-length tuples #14184

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7bb0cdc
Add test cases from #12134 by @sobolevn
JukkaL Nov 24, 2022
2a1ab2d
Extract fix from #14181
JukkaL Nov 24, 2022
68719a5
Update test cases
JukkaL Nov 24, 2022
bdc6cf1
Update test case
JukkaL Nov 24, 2022
a66c057
Add TODOs about using type application to create a tuple
JukkaL Nov 24, 2022
68b369e
Fix test case
JukkaL Nov 24, 2022
3ee9193
Update test case
JukkaL Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test case
  • Loading branch information
@JukkaL
JukkaL committed Nov 25, 2022
commit 68b369ec607b82955d0ea8c8c36abaa71e5b79e6
6 changes: 3 additions & 3 deletions mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3968,10 +3968,10 @@ def apply_type_arguments_to_callable(
tp = get_proper_type(tp)

if isinstance(tp, CallableType):
if tp.is_type_obj() and tp.type_object().fullname == "builtins.tuple":
# TODO: Specialize the callable for the type arguments
return tp
if len(tp.variables) != len(args):
if tp.is_type_obj() and tp.type_object().fullname == "builtins.tuple":
# TODO: Specialize the callable for the type arguments
return tp
self.msg.incompatible_type_application(len(tp.variables), len(args), ctx)
return AnyType(TypeOfAny.from_error)
return self.apply_generic_arguments(tp, args, ctx)
Expand Down