Add import Union to stub file (#12929) #13428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilvestrLanik
force-pushed
the
Adding_union_imports
branch
from
88ac62e
to
9e88224
Compare
|
I've fixed the formatting and failing test :-) |
sobolevn
reviewed
Sep 11, 2022
| def foo(a: str | None): | ||
| pass | ||
| [out] | ||
| from typing import Union |
There was a problem hiding this comment.
Can you please also add Optional to the test? It is highly related to Union as well.
hamdanal
added a commit
to hamdanal/mypy
that referenced
this pull request
Feb 3, 2023
When a PEP 604 Union exists in the runtime, stubgen was generating a `Union[...]` syntax without importing `Union` from `typing`. With this change, stubgen preserves the ` | `-unions in the output. Fixes python#12929 Closes python#13428 Ref python#12920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12929
Stubs generated from files with new format of Union typing will include importing Union from typing.
Test Plan
I've added 3 new tests while making sure they pass locally.