Don't skip magic-trailing-comma [black] #13418
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to discussion in #13412 (comment)
Remove black setting to
skip-maagic-trailing-comma
since in some instances it can result in better readable code. With the setting enabled, black will always choose the most compact function definition even if it isn't the best solution.https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#the-magic-trailing-comma
Initial comment adding it: #12424 (comment)
Test Plan
I've reapplied the changes suggested in #13412 (review) to show the impact of the setting change.