Remove use of LiteralString in builtins #13093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: porcupine (https://github.com/Akuli/porcupine)
- porcupine/plugins/editorconfig.py:152: error: Argument 1 to "map" has incompatible type "Callable[[AnyStr], AnyStr]"; expected "Callable[[str], AnyStr]" [arg-type]
- porcupine/plugins/pluginmanager.py:133: error: Argument 1 to "map" has incompatible type "Callable[[AnyStr], AnyStr]"; expected "Callable[[str], AnyStr]" [arg-type]
core (https://github.com/home-assistant/core)
- homeassistant/components/sonos/media.py:180: error: List item 0 has incompatible type "Optional[str]"; expected "None" [list-item]
streamlit (https://github.com/streamlit/streamlit)
+ lib/tests/streamlit/legacy_caching/hashing_test.py:253:30: error: Unsupported operand types for + ("str" and "int") [operator]
- lib/tests/streamlit/legacy_caching/hashing_test.py:253:24: error: No overload variant of "__add__" of "str" matches argument type "int" [operator]
- lib/tests/streamlit/legacy_caching/hashing_test.py:253:24: note: Possible overload variants:
- lib/tests/streamlit/legacy_caching/hashing_test.py:253:24: note: def __add__(self, str) -> str
aiohttp (https://github.com/aio-libs/aiohttp)
- aiohttp/multipart.py:95: error: Argument 1 to "map" has incompatible type "Callable[[AnyStr], AnyStr]"; expected "Callable[[str], AnyStr]" [arg-type]
|
JukkaL
approved these changes
Jul 8, 2022
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Jul 8, 2022
Fixes python#13091 Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
Merged
hauntsaninja
added a commit
that referenced
this pull request
Jul 8, 2022
Source commit: python/typeshed@b145b32 This reapplies #13093. This will likely be the last sync that still has support for Python 3.6.
Merged
ilevkivskyi
added a commit
to ilevkivskyi/mypy
that referenced
this pull request
Jul 27, 2022
Fixes python#13091 Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
hauntsaninja
pushed a commit
that referenced
this pull request
Jul 28, 2022
Source commit: python/typeshed@5397d43 Remove use of LiteralString in builtins (#13093)
Merged
Gobot1234
pushed a commit
to Gobot1234/mypy
that referenced
this pull request
Aug 12, 2022
Fixes python#13091 Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
Gobot1234
pushed a commit
to Gobot1234/mypy
that referenced
this pull request
Aug 12, 2022
Source commit: python/typeshed@b145b32 This reapplies python#13093. This will likely be the last sync that still has support for Python 3.6.
jhance
pushed a commit
that referenced
this pull request
Aug 17, 2022
Fixes #13091 Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
Merged
Merged
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Sep 26, 2022
Updated version of python#13093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13091