Automatically Detect Argument Defaults in attrs-Equivalent Decorators #12775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
changed the title
This comment has been minimized.
This comment has been minimized.
t4lz
force-pushed
the
attrs-wrappers-support
branch
from
9111471 to
89dec25
Compare
|
Rebased on |
This comment has been minimized.
This comment has been minimized.
Instead of relying only on hardcoded default value, first try to find out the actuall default value of a bool argument to a the class/attrib-maker decorators, and only if the value could not be extracted from the code, fall back to the default value defined in mypy. This enables the correct handling of decorators which wrap attrs decorators but set different defaults, for example to kw_only. This commit also adds to test cases. testAttrsWrappedDecorators tests the existing support for wrapping attrs decorators, via a "fake plugin" and testAttrsWrappedDecoratorsWithDifferentDefaults tests the new support for decorators that have different default values than the attrs decorators.
t4lz
force-pushed
the
attrs-wrappers-support
branch
from
89dec25 to
d661abb
Compare
This comment has been minimized.
This comment has been minimized.
|
I think I'm ready for review :) |
|
Hey, is it likely this PR would be reviewed if I resolve the new conflicts? |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
t4lz
force-pushed
the
attrs-wrappers-support
branch
from
9f5a3d9 to
ee91e41
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12774
Instead of relying only on hardcoded default value, first try to find out the actuall default value of a bool argument to a the class/attrib-maker decorators, and only if the value could not be extracted from the code, fall back to the default value defined in mypy.
This enables the correct handling of decorators which wrap attrs decorators but set different defaults, for example to kw_only.
Test Plan
This commit also adds two test cases.
testAttrsWrappedDecoratorstests the existing support for wrapping attrs decorators, via a "fake plugin" andtestAttrsWrappedDecoratorsWithDifferentDefaultstests the new support for decorators that have different default values than the attrs decorators.