-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enums: Teach mypy that descriptors are not converted to become enum members #12669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
changed the title
Make enums with only descriptor members subclassable
Enums: Teach mypy that descriptors are not converted to become enum members
Apr 26, 2022
This comment has been minimized.
This comment has been minimized.
AlexWaygood
force-pushed
the
descriptor-enums
branch
from
April 26, 2022 20:48
a42b0d8
to
e27c387
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
commented
Aug 19, 2022
This comment has been minimized.
This comment has been minimized.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
I doubt I'll get to this any time soon |
For what it's worth: this issue is very difficult to work around using Any suggestions would be most welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12494.
Description
At runtime, most objects in an enum class statement are automatically converted by the enum module into members of the enumeration. However, if an object has a
__get__
,__set__
or__delete__
method, special-casing by theenum
module means that the object is not converted into an enum member. Mypy is currently aware of this special-casing, leading it to falsely assume that certain enum classes are unsubclassable, when, in fact, they are.This PR teaches mypy about descriptor special-casing in enums.
Test Plan