Allow non-final __match_args__ and overriding #12415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's okay to modify the definition of `__match_args__` in subclasses.
JelleZijlstra
approved these changes
Mar 21, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Diff from mypy_primer, showing the effect of this PR on open source code: ppb-vector (https://github.com/ppb/ppb-vector)
- ppb_vector/__init__.py:107: note: __match_args__ must be final for checking of match statements to work
|
JukkaL
added a commit
that referenced
this pull request
Mar 22, 2022
Allow subclasses to override `__match_args__` freely, and don't require `__match_args__` to be final. This matches runtime behavior. For example, if `B` subclasses `A`, `case A(...)` also matches instances of `B`, using the `__match_args__` from `A`. The issue was brough up by @AlexWaygood in #12411 (comment).
AlexWaygood
added a commit
to AlexWaygood/mypy
that referenced
this pull request
Mar 26, 2022
python#12415 (included in release 0.942) unblocked typeshed from adding missing `__match_args__` attributes (see python/typeshed#7556). This means stubtest is now unblocked from checking the correctness of `__match_args__` attributes in the stub!
JelleZijlstra
pushed a commit
that referenced
this pull request
Mar 27, 2022
#12415 (included in release 0.942) unblocked typeshed from adding missing `__match_args__` attributes (see python/typeshed#7556). This means stubtest is now unblocked from checking the correctness of `__match_args__` attributes in the stub!
|
I'm pleased to confirm that this fixed the issue for typeshed — typeshed has now added missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow subclasses to override
__match_args__freely, and don't require__match_args__to be final.This matches runtime behavior. For example, if
BsubclassesA,case A(...)also matches instances ofB, using the__match_args__from
A.The issue was brough up by @AlexWaygood in
#12411 (comment).