Consider column numbers when removing duplicate errors

[KotlinIsland]

Description

def foo(a: int) -> int: ...

(foo(""), foo(""),)
(
    foo(""),
    foo(""),
)

main.py:3:6: error: Argument 1 to "foo" has incompatible type "str"; expected "int"  [arg-type]
main.py:5:9: error: Argument 1 to "foo" has incompatible type "str"; expected "int"  [arg-type]
main.py:6:9: error: Argument 1 to "foo" has incompatible type "str"; expected "int"  [arg-type]
Found 3 errors in 1 file (checked 1 source file)

It's misleading to hide similar errors when they appear on the same line, especially when those errors are shown inline in an IDE.

When all the errors aren't shown, the write / check / fix cycle is heavily impacted.

After this PR:

main.py:3:6: error: Argument 1 to "foo" has incompatible type "str"; expected "int"  [arg-type]
main.py:3:15: error: Argument 1 to "foo" has incompatible type "str"; expected "int"  [arg-type]
main.py:5:9: error: Argument 1 to "foo" has incompatible type "str"; expected "int"  [arg-type]
main.py:6:9: error: Argument 1 to "foo" has incompatible type "str"; expected "int"  [arg-type]
Found 3 errors in 1 file (checked 1 source file)

Test Plan

I don't think there need to be any tests for this, as it is currently covered by several other tests.

The tests that I've updated have unearthed a couple of bugs related to column numbers(#12272, #12271, and #12274). All of the alterations to the tests in this pr look like situations where I would want to know about multiple errors appearing(except the defective ones mentioned).

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

spark (https://github.com/apache/spark)
+ python/pyspark/sql/pandas/types.py:216: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/types.py:216: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/types.py:405: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/types.py:405: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/types.py:415: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/types.py:415: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/map_ops.py:329: error: Name "DataFrameLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/group_ops.py:255: error: Name "DataFrameLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/group_ops.py:256: error: Name "DataFrameLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/group_ops.py:333: error: Name "DataFrameLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/group_ops.py:333: error: Name "DataFrameLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:255: error: Name "DataFrameLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:256: error: Name "DataFrameLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:264: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:265: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:265: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:266: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:266: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:266: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:267: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:267: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:267: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:267: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:269: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:269: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:269: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:269: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/functions.pyi:269: error: Name "SeriesLike" is not defined  [name-defined]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:42: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:255: error: Variable "pyspark.sql.pandas._typing.DataFrameLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:255: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:256: error: Variable "pyspark.sql.pandas._typing.DataFrameLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:256: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:264: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:264: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:265: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:265: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:265: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:265: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:266: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:266: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:266: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:266: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:266: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:266: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:267: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:267: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:267: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:267: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:267: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:267: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:267: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:267: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: error: Variable "pyspark.sql.pandas._typing.SeriesLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:269: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:329: error: Variable "pyspark.sql.pandas._typing.DataFrameLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:329: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:333: error: Variable "pyspark.sql.pandas._typing.DataFrameLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:333: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ python/pyspark/sql/pandas/_typing/__init__.pyi:333: error: Variable "pyspark.sql.pandas._typing.DataFrameLike" is not valid as a type  [valid-type]
+ python/pyspark/sql/pandas/_typing/__init__.pyi:333: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases

jax (https://github.com/google/jax)
+ jax/_src/dispatch.py:181: error: Variable "jax._src.dispatch.Device" is not valid as a type  [valid-type]
+ jax/_src/dispatch.py:181: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ jax/_src/dispatch.py:939: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ jax/interpreters/xla.py:542: error: Variable "jax.interpreters.xla.XlaOp" is not valid as a type  [valid-type]
+ jax/interpreters/xla.py:542: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ jax/interpreters/pxla.py:112: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ jax/interpreters/pxla.py:112: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ jax/interpreters/pxla.py:113: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ jax/experimental/global_device_array.py:496: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases

ibis (https://github.com/ibis-project/ibis)
+ ibis/expr/rules.py:198: error: Cannot determine type of "any"
+ ibis/expr/format.py:78: error: Value of type "Iterable[str]" is not indexable
+ ibis/tests/expr/test_datatypes.py:23: error: Too many arguments for "Array"
+ ibis/tests/expr/test_datatypes.py:27: error: Too many arguments for "Map"
+ ibis/tests/expr/test_datatypes.py:456: error: Too many arguments for "Interval"
+ ibis/tests/expr/test_datatypes.py:472: error: Too many arguments for "Interval"
+ ibis/backends/pandas/tests/test_datatypes.py:63: error: Too many arguments for "Array"
+ ibis/tests/expr/test_value_exprs.py:1533: error: Too many arguments for "Array"
+ ibis/tests/expr/test_value_exprs.py:1539: error: Too many arguments for "Array"
+ ibis/backends/duckdb/tests/test_datatypes.py:56: error: Too many arguments for "Array"
+ ibis/backends/duckdb/tests/test_datatypes.py:59: error: Too many arguments for "Array"
+ ibis/backends/duckdb/tests/test_datatypes.py:60: error: Too many arguments for "Array"

prefect (https://github.com/PrefectHQ/prefect)
+ src/prefect/exceptions.py:195: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/exceptions.py:195: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/utilities/pydantic.py:155: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/utilities/pydantic.py:155: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/software/pip.py:25: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/software/pip.py:25: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/blocks/core.py:428: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/blocks/core.py:428: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/software/python.py:26: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/software/python.py:26: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/software/python.py:41: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/software/python.py:41: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/blocks/kubernetes.py:44: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/blocks/kubernetes.py:44: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/software/conda.py:118: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/software/conda.py:118: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/software/conda.py:141: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/software/conda.py:141: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/client.py:229: error: Variable "typing_extensions.Self" is not valid as a type
+ src/prefect/client.py:229: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ src/prefect/context.py:112: error: Type variable "prefect.context.T" is unbound
+ src/prefect/context.py:112: note: (Hint: Use "Generic[T]" or "Protocol[T]" base class to bind "T" inside a class)
+ src/prefect/context.py:112: note: (Hint: Use "T" in function signature to bind "T" inside a function)
+ src/prefect/context.py:117: error: Type variable "prefect.context.T" is unbound
+ src/prefect/context.py:117: note: (Hint: Use "Generic[T]" or "Protocol[T]" base class to bind "T" inside a class)
+ src/prefect/context.py:117: note: (Hint: Use "T" in function signature to bind "T" inside a function)

steam.py (https://github.com/Gobot1234/steam.py)
+ steam/enums.py:177: error: Variable "typing_extensions.Self" is not valid as a type  [valid-type]
+ steam/enums.py:177: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ steam/enums.py:212: error: Variable "typing_extensions.Self" is not valid as a type  [valid-type]
+ steam/enums.py:212: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ steam/enums.py:216: error: Variable "typing_extensions.Self" is not valid as a type  [valid-type]
+ steam/enums.py:216: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ steam/utils.py:175: error: Parameter 1 of Literal[...] is invalid  [misc]
+ steam/utils.py:264: error: Parameter 1 of Literal[...] is invalid  [misc]
+ steam/utils.py:264: error: Parameter 1 of Literal[...] is invalid  [misc]
+ steam/abc.py:641: error: Name "CommentPrivacyState" is not defined  [name-defined]
+ steam/manifest.py:165: error: Variable "typing_extensions.Self" is not valid as a type  [valid-type]
+ steam/manifest.py:165: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ steam/game_server.py:23: error: Cannot resolve name "Q" (possible cyclic definition)  [misc]
+ steam/game_server.py:239: error: "Unpack" is not supported by mypy yet  [misc]
+ steam/clan.py:244: error: Self? has no attribute "game"  [attr-defined]
+ steam/ext/commands/cooldown.py:52: error: Item "Messageable[Any]" of "Union[Message, Messageable[Any]]" has no attribute "clan"  [union-attr]
+ steam/ext/commands/cooldown.py:56: error: Item "Messageable[Any]" of "Union[Message, Messageable[Any]]" has no attribute "author"  [union-attr]
+ steam/ext/commands/cooldown.py:62: error: Item "Messageable[Any]" of "Union[Message, Messageable[Any]]" has no attribute "clan"  [union-attr]
+ steam/ext/commands/cooldown.py:62: error: Item "Messageable[Any]" of "Union[Message, Messageable[Any]]" has no attribute "author"  [union-attr]

manticore (https://github.com/trailofbits/manticore)
+ tests/auto_generators/make_dump.py:204: error: Name "CS_ARCH_X86" is not defined
+ tests/auto_generators/make_dump.py:251: error: Name "B" is not defined

discord.py (https://github.com/Rapptz/discord.py)
+ discord/flags.py:122: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:122: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/flags.py:125: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:125: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/flags.py:128: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:128: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/flags.py:131: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:131: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/flags.py:135: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:135: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/flags.py:139: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:139: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/flags.py:1493: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:1493: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/flags.py:1578: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:1578: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/flags.py:1587: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/flags.py:1587: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/user.py:123: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/user.py:123: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/member.py:198: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/member.py:198: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/member.py:407: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/member.py:407: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/ext/commands/core.py:554: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/ext/commands/core.py:554: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/ext/commands/hybrid.py:533: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/ext/commands/hybrid.py:533: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+ discord/ext/commands/hybrid.py:690: error: Variable "typing_extensions.Self" is not valid as a type
+ discord/ext/commands/hybrid.py:690: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases