Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enum final props and writable special members #11945

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix Enum final props and writable special members #11945

merged 1 commit into from
Jan 10, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 9, 2022

Closes #11820

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2022

Diff from mypy_primer, showing the effect of this PR on open source code:

psycopg (https://github.com/psycopg/psycopg)
- psycopg/psycopg/pq/_enums.py:15: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/pq/_enums.py:43: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/pq/_enums.py:62: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/pq/_enums.py:129: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/pq/_enums.py:150: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/pq/_enums.py:176: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/pq/_enums.py:199: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/pq/_enums.py:230: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/pq/_enums.py:243: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/_enums.py:23: error: Cannot override writable attribute "__module__" with a final one  [misc]
- psycopg/psycopg/_enums.py:46: error: Cannot override writable attribute "__module__" with a final one  [misc]

@97littleleaf11 97littleleaf11 merged commit f6ebf10 into python:master Jan 10, 2022
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
@sobolevn @tushar-deepsource
Fix Enum final props and writable special members, refs python#11820 (
e7dbc70 
python#11945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@97littleleaf11 97littleleaf11 97littleleaf11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in mypy 0.930: Cannot override writable attribute "__module__" with a final one
2 participants
@sobolevn @97littleleaf11