Fix function containing PEP 593 Annotated with a string literal second arg causing 'Name "x" is not defined" error #10777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d result in 'Name "x" is not defined' errors.
| pass | ||
| reveal_type(f1) # N: Revealed type is "def (a: builtins.str) -> Any" | ||
| def f2(a: Annotated["str", "metadata"]): | ||
| pass |
There was a problem hiding this comment.
Could you reveal_type() this one too?
There was a problem hiding this comment.
And maybe also add a testcase with a generic function, so we can confirm that a typevar in the first arg to Annotated is still picked up correctly.
There was a problem hiding this comment.
@JelleZijlstra I added a case. Is it correct?
JelleZijlstra
approved these changes
Nov 26, 2021
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
…d arg causing 'Name "x" is not defined" error (python#10777) Fixes python#9868 When analyzing function definitions, mypy attempts to infer type variables. The code which did that also tried to look into the second type arg to `Annotated`, which, if a string literal, resulted in a lookup which may cause a 'Name "x" is not defined" error. Co-authored-by: 97littleleaf11 <97littleleaf11@users.noreply.github.com> Co-authored-by: Jingchen Ye <97littleleaf11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9868
When analyzing function definitions, mypy attempts to infer type variables. The code which did that also tried to look into the second type arg to
Annotated, which, if a string literal, resulted in a lookup which may cause a 'Name "x" is not defined" error.Test Plan
Test was added for this case, which previously failed.
Tests were added to ensure that the first type var to
Annotatedwas still analyzed correctly.