Try ignoring Anys in type object callables for purposes of overload ambiguity #10734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbiguity I believe this should help with some issues that come up with #10694.
JukkaL
approved these changes
Jun 29, 2021
pranavrajpal
added a commit
to pranavrajpal/mypy
that referenced
this pull request
Jun 29, 2021
The first test makes sure the return type of the first register call doesn't get turned to Any, which happens because mypy thinks there is ambiguity around which overload variant of register to pick (ConstExpr matches both Type[Any] and Callable[..., _T]). That should get fixed by python#10734. The second test makes sure we handle cases where we try to type check a call before we've seen all the relevant registered implementations, which didn't work when we were trying to find all registered implementations and figure out which ones might get called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should help with some issues that come up with #10694.