-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tuple multiply literal #10361
Tuple multiply literal #10361
Conversation
This comment has been minimized.
This comment has been minimized.
mypy-primer found it crashing at https://github.com/google/jax/blob/master/jax/_src/lax/other.py#L96, apparently on a |
Fixed in commit. I think at least. It doesn't comment if no diff.
…On Fri, Apr 23, 2021, 17:12 Jelle Zijlstra ***@***.***> wrote:
mypy-primer found it crashing at
https://github.com/google/jax/blob/master/jax/_src/lax/other.py#L96,
apparently on a Tuple[int, ...].
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10361 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYQXXOEHDGRBDFPVU3MTNDTKF56LANCNFSM43OR2TWQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Looks good, I'd just prefer to have these tests use the test fixtures instead of full stubs, since tests using full stubs are a lot slower to run.
Done as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! Looks good based on a quick review pass.
Since we are (hopefully) close to a mypy release, I won't merge this until I've cut a release branch. Changes to type inference frequently have hard-to-find edge cases, so I'd prefer to merge this early in a release process to that there will be more time for testing.
Description
Fixes #863.
I've added a method hook that given an int literal multiplied by a tuple gives the correct specific sized tuple.
Test Plan
I've added more python evaulation tests and mypy_primer should cover enough of a regression test.