Support @no_type_check for classes #10162
Conversation
| if not any(refers_to_fullname(decorator, | ||
| 'typing.no_type_check') | ||
| for decorator in defn.decorators): | ||
| self.accept(defn.defs) |
There was a problem hiding this comment.
Type checking populates some information that other parts of the type checker may rely on. So this needs to be more elaborate.
For example, this shouldn't generate errors:
import typing
@typing.no_type_check
class A:
a = int()
def f(self) -> None:
self.b = int()
a = A()
a.a # Cannot determine type of "a"
a.b # Cannot determine type of "b"One way to deal with this is to give everything in the class the type Any. We'd still no type checking, but it actually wouldn't do much. We use in_checked_function() in mypy.checker to do this. You can add some check for no_type_check decorator there (maybe via a bool attribute flag) so that in_checked_function() returns False inside the class.
|
This now has merge conflicts, and Jukka's review from two years ago still hasn't been addressed,so I'm closing this PR. If you're still interested in working on this issue, please feel free to open a new PR @kamilturek! |
Description
Closes #607.
Skip checking class scope if
typing.no_type_checkdecorator has been applied on class definition.