Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all names and fullnames in mypy properties #7640

Closed
msullivan opened this issue Oct 5, 2019 · 5 comments · Fixed by #7829
Closed

Make all names and fullnames in mypy properties #7640

msullivan opened this issue Oct 5, 2019 · 5 comments · Fixed by #7829
Labels
needs discussion refactoring Changing mypy's internals

Comments

@msullivan
Copy link
Collaborator

^
@msullivan msullivan added refactoring Changing mypy's internals needs discussion labels Oct 5, 2019
@msullivan
Copy link
Collaborator Author

Oh ugh this would be a big plugin compatability break wouldn't it

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 7, 2019

Yeah, but on the other hand it would be good to do this before 1.0 release since the current situation is bad. I'd rather not be stuck with the current state forever.

@ilevkivskyi
Copy link
Member

I agree with Jukka here.

@ethanhs
Copy link
Collaborator

ethanhs commented Oct 7, 2019

I think this is probably a good idea. If we choose to move ahead with this, we should probably announce our intentions here ASAP #6617

@msullivan
Copy link
Collaborator Author

OK I'll do it after 0.740

@msullivan msullivan mentioned this issue Oct 30, 2019
Merged
msullivan added a commit that referenced this issue Nov 13, 2019
@msullivan
Make all names and fullnames into properties (#7829)
e97377c 
SymbolNode and FuncBase had name and fullname as methods while everything else has them as attributes or properties. Turn them into properties.

Fixes #7640.

This was done with `sed -i -e 's/\.name()/.name/g' -e 's/\.fullname()/.fullname/g' mypy/*.py mypy/*/*.py mypyc/*.py mypyc/*/*.py misc/proper_plugin.py test-data/unit/plugins/*.py`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs discussion refactoring Changing mypy's internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make all names and fullnames into properties python/mypy
4 participants
@msullivan @JukkaL @ethanhs @ilevkivskyi