Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New semantic analyzer: visit decorators that are parts of overloads as a part of module top-level #6357

Closed
ilevkivskyi opened this issue Feb 7, 2019 · 1 comment
Closed

New semantic analyzer: visit decorators that are parts of overloads as a part of module top-level #6357

ilevkivskyi opened this issue Feb 7, 2019 · 1 comment
Labels
priority-1-normal semantic-analyzer Problems that happen during semantic analysis

Comments

@ilevkivskyi
Copy link
Member

Currently, only non-overloaded decorators are visited as a part of module top-level. This causes problems with detecting overloaded abstract methods.
@ilevkivskyi ilevkivskyi added priority-1-normal semantic-analyzer Problems that happen during semantic analysis labels Feb 7, 2019
@ilevkivskyi ilevkivskyi mentioned this issue Feb 7, 2019
Merged
ilevkivskyi added a commit that referenced this issue Feb 12, 2019
@ilevkivskyi
New semantic analyzer: Support builtin typing aliases (#6358)
2ef066f 
Fixes #6297

This adds support for real typeshed stubs that define dummy aliases like `typing.List`, `typing.Dict`, etc. This also fixes couple related issues, so that builtin SCC is almost clean (the two remaining errors are #6295 and #6357).

Most notably, this PR introduces some re-ordering of targets in builtin SCC, removing this reordering requires some non-trivial work (namely #6356, #6355, and deferring targets from `named_type()`).
@ilevkivskyi
Copy link
Member Author

This was essentially fixed by #6423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-normal semantic-analyzer Problems that happen during semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilevkivskyi