Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pythoneval tests using --incremental #5083

Closed
ilevkivskyi opened this issue May 18, 2018 · 3 comments
Closed

Run pythoneval tests using --incremental #5083

ilevkivskyi opened this issue May 18, 2018 · 3 comments
Labels
priority-1-normal topic-tests

Comments

@ilevkivskyi
Copy link
Member

There is a simple idea how to speed-up pythoneval.py tests, that are currently very slow. After running the first test we can write cache and use it for the next test, so that we don't reprocess builtins, typing, etc.
@ethanhs
Copy link
Collaborator

ethanhs commented May 18, 2018

I believe the tests are run without the --no-incremental flag, so they are run in incremental mode (since it is on by default now), but discard the cache on cleanup, no? So really we want to keep the created cache?

@ilevkivskyi
Copy link
Member Author

So really we want to keep the created cache?

Yes, this is what I mean.

This was referenced May 18, 2018
Closed
Closed
@ilevkivskyi
Copy link
Member Author

This is actually a duplicate of #1412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-normal topic-tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethanhs @ilevkivskyi