Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast parser should warn about using ellipses with other function arguments #2704

Closed
ddfisher opened this issue Jan 18, 2017 · 0 comments · Fixed by #2722
Closed

Fast parser should warn about using ellipses with other function arguments #2704

ddfisher opened this issue Jan 18, 2017 · 0 comments · Fixed by #2722
Assignees

Comments

@ddfisher
Copy link
Collaborator

For this function:

def f(x, y, z): # type: (..., int) -> None
     pass

The old parser would give the warning: Ellipses cannot accompany other argument types in function type signature., whereas the fast parser gives the less helpful Type signature has too few arguments.

The fast parser should look for ellipses args and give a special-cased better error message.

@ddfisher ddfisher self-assigned this Jan 18, 2017
gvanrossum pushed a commit that referenced this issue Jan 23, 2017
This PR converts 3 more test files to the fast parser. To do so, we add support for the @no_type_check decorator and fixup the error message about mixed ellipses arguments (i.e. fixes #2704).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant