Make testCoberturaParser in cmdline.test work on Windows, or skip just this test

[gvanrossum]

When you run cmdline.test on Windows you get an error on testCoberturaParser.

• When lxml is not installed this fails to find the expected output because this test is for the --cobertura-xml-report option which requires lxml, and such options are silently ignored when lxml is not installed.
• When lxml is installed this fails because the expected output contains some UNIX-specific filenames.

We currently deal with this by skipping all "cmdline" tests in our Windows appveyor.yml, but that's sub-optimal because it means that the command line flags are not tested at all there.

We can either delete the test (but then the feature will probably rot without anyone noticing), or move it to a separate category that is skipped on Windows only (which is more work).

[alexandrul]

If it's ok to use some kind of a flag to signal that the test suite is executed under windows, it could be as easy as replacing \ with / for the relative file path in CoberturaXmlReporter.on_file

[gvanrossum]

Detecting Windows is easy enough (sys.platform == "win32"). It's perhaps a little bit weird to normalize paths to using forward / on Windows, but all in all I think it's a reasonable compromise, so let's give it a try.

[alexandrul]

True, but I don't see a reason to use linux path sep under windows for usual operations.
I would make this change only for the tests, to keep the expected output unchanged.

How can I detect that the code is called as part of the tests?

[gvanrossum]

Heh, I see. That's problematic, perhaps we should change the test suite to allow changing paths in expected/actual output? That's being done already for paths in error output.

…

--Guido (mobile)

On Feb 5, 2017 11:27 AM, "Eduard-Cristian Stefan" ***@***.***> wrote: True, but I don't see a reason to use linux path sep under windows for usual operations. I would make this change only for the tests, to keep the expected output unchanged. How can I detect that the code is called as part of the tests? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2663 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACwrMrlJfZBpY56Ciol3kf6vFqpKL3oGks5rZiKtgaJpZM4Le1rn> .

[alexandrul]

I've got it working. I have opened #2814 for adding lxml on AppVeyor (and running the reports tests), next step would be the PR for this fix.

[alexandrul]

Just opened #2815