Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider --extra-checks #18070

Open
hauntsaninja opened this issue Oct 30, 2024 · 1 comment
Open

Reconsider --extra-checks #18070

hauntsaninja opened this issue Oct 30, 2024 · 1 comment
Labels
meta Issues tracking a broad area of work topic-configuration Configuration files and flags

Comments

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Oct 30, 2024

--extra-checks was added per this review comment: #15425 (comment)

I think a big advantage of mypy relative to other type checkers is that it is relatively configurable. mypy's always had a number of config flags and the error code system that we've been encouraging allows users to enable and disable errors with granularity.

--extra-checks is not self-descriptive, it's not immediately obvious what it turns on or off. If I was a user and ran into a false positive/negative, I would not be able to connect it with the option. It's also part of --strict, so it's not even that extra — most users serious enough about type checking to know what the flag does will already have it on. I vote we keep --strict-concatenate and add --strict-typeddict-update. We can keep both of these as part of --strict and keep --extra-checks for backwards compatibility.

If we want to do more bundling of flags / error codes, I feel we should generalise --strict.

@cdce8p cdce8p added meta Issues tracking a broad area of work topic-configuration Configuration files and flags and removed feature labels Oct 30, 2024
@sobolevn
Copy link
Member

sobolevn commented Nov 4, 2024

I agree, let's do that for mypy@2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues tracking a broad area of work topic-configuration Configuration files and flags
Projects
None yet
Development

No branches or pull requests

3 participants