no error when calling abstract staticmethod/classmethod

[DetachHead]

from abc import ABC, abstractmethod

class Foo(ABC):
    @staticmethod
    @abstractmethod
    def foo() -> Foo:
        ...


Foo.foo() # no error

playground

[JukkaL]

Note that the error is currently only generated when constructing an instance, since when calling a method on an instance, the runtime object could be an instance of a subclass with the method implemented.

We'd need to add add a new check when accessing an abstract static method (possibly also class method) of a direct reference to a type object, but not when using type[T], since again we might have an instance of a subclass. I think that a direct reference has a type CallableType, whereas type[T] has type TypeType.

[madt2709]

Hi, I was looking into picking this up but was unsure where was the best place in the code to put this in. I have created a test to reproduce and the bug still exists. Should this be a separate check within checkexpr.py (particularly in the check_callable_call) or should it be within the checker.py file or somewhere completely different?

[erictraut]

This is (largely) a duplicate of #14939. As Jukka says, the current behavior is to report the problem when an abstract class is instantiated. This mirrors the error seen at runtime. And as discussed in the duplicate issue, there's a good reason not to emit an error when a class method or static method is called here. Recommend closing.

[JelleZijlstra]

#14939 is this issue, which one were you thinking of?

[erictraut]

Oops, I meant #14062.

[JelleZijlstra]

Thanks, I feel this one different and more reasonable as a feature request, as here the ask is to warn about calls to abstract static/classmethods, while #14062 wanted a warning for calls to non-abstract static/classmethods on abstract classes. Jukka's comment above explains how such a check could be implemented.

[keshavt3]

I want to work on this.