Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement monitoring for the mypy wheel build #11532

Open
JukkaL opened this issue Nov 12, 2021 · 3 comments
Open

Implement monitoring for the mypy wheel build #11532

JukkaL opened this issue Nov 12, 2021 · 3 comments

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Nov 12, 2021

I think that at least two mypy releases have been delayed because the mypy wheel build (https://github.com/mypyc/mypy_mypyc-wheels) was broken and nobody noticed it for some time. It would be great if anybody interested in the health of the build could sign up to receive email notifications about build failures.

This blog post may be relevant (not sure though): https://ravgeetdhillon.medium.com/send-an-email-notification-when-github-actions-fails-ea83cbeabbe0

Steps:

  1. Figure out a way of allowing people for subscribe to notifications (Google group?)
  2. Implement email notifications
  3. Break the build on purpose and check that a notification gets sent (both on master and in a release branch)
  4. Unbreak the build

It would be great if somebody can look into this. If you need access to the wheels repo, please let me know and I can give you the access you'd need.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Nov 12, 2021

As a first step, just having a hard coded list of email addresses in the repository would also be okay. If people wish to subscribe, they can send a PR to add their email address.

@A5rocks
Copy link
Contributor

A5rocks commented Nov 12, 2021

It sounds like you can get an email/notification from github itself without any of this, as long as you are watching the repository:

https://docs.github.com/en/account-and-profile/managing-subscriptions-and-notifications-on-github/setting-up-notifications/configuring-notifications#github-actions-notification-options

(Not sure though)

@JukkaL
Copy link
Collaborator Author

JukkaL commented Nov 17, 2021

It sounds like you can get an email/notification from github itself without any of this, as long as you are watching the repository

Hmm it turns out I'm getting emails, but they are super noisy so I've been filtering them. I can probably just filter out emails about successful builds, which would solve my original issue (at least for me). Still, it would be nice to only get emails about failing builds, but at least there's a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants