Skip to content
This repository was archived by the owner on Apr 10, 2022. It is now read-only.

reword split() definition to get around the virtual subclass issue #29

Merged
merged 1 commit into from
Feb 16, 2021
Merged

reword split() definition to get around the virtual subclass issue #29

merged 1 commit into from
Feb 16, 2021

Conversation

iritkatriel
Copy link
Member

No description provided.

gvanrossum
gvanrossum approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new wording. And I suppose the "virtual subclass issue" is about the use (or not) of __instancecheck__?

@iritkatriel
Copy link
Member Author

And I suppose the "virtual subclass issue" is about the use (or not) of __instancecheck__?

Yes, following this discussion: iritkatriel/cpython#7 (comment)

@iritkatriel iritkatriel merged commit 6cb455f into master Feb 16, 2021
@iritkatriel iritkatriel deleted the split branch February 16, 2021 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iritkatriel @gvanrossum