This repository was archived by the owner on Apr 10, 2022. It is now read-only.
Typos. Reference Implementation description. Added a rejected idea. #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Feb 8, 2021
1st1
reviewed
Feb 8, 2021
| [`MultiError` type](https://trio.readthedocs.io/en/stable/reference-core.html#trio.MultiError). | ||
| However, such approaches require calling code to catch the container exception | ||
| type, and then inspect it to determine the types of errors that had occurred, | ||
| extract the ones it wants to handle and reraise the rest. |
There was a problem hiding this comment.
Perhaps we can add a link to show that "... require calling code to catch the container exception reraise the rest. type, and then inspect it to determine the types of errors ..." is very cumbersome and unintuitive.
Also, having custom multi error implementations in multiple packages makes it very hard to use them together in one project.
There was a problem hiding this comment.
Feel free to make a PR with such changes. I'm not editing now.
1st1
reviewed
Feb 8, 2021
1st1
reviewed
Feb 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.