Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Nov 13, 2025

Fixes:

image

That is, the CI is run twice.


📚 Documentation preview 📚: https://docs-community--171.org.readthedocs.build/

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't disable pushes for feature branches, I want to test on my fork before opening a PR.

@bskinn
Copy link

bskinn commented Nov 14, 2025

Please don't disable pushes for feature branches, I want to test on my fork before opening a PR.

Could add an opt-in flag instead of disabling entirely.
[run ci], say... the opposite of [skip ci].

@hugovk
Copy link
Member

hugovk commented Nov 14, 2025

I don't think it's worth it:

  • First, we shouldn't create PRs from branches in this repo -- do it from your fork.
  • The CI is disabled by default for forks, so it'll only run in your fork when you have explicitly enabled it.
  • If you've enabled it for your fork, you have full control to disable it.
  • Technically speaking, these are not duplicate runs. The push trigger runs whatever is on the branch. The PR trigger simulates a merge and runs that, which sometimes has different results and fails in one but not the other.
  • The CI only takes 12 seconds to run.

Root cause: #170 was made from a branch in this repo and had the "duplicate" CI.

Should triagers have write permission to create branches here?

Should the core team?

We've disabled it for some repos (cpython, peps).

@StanFromIreland
Copy link
Member Author

Root cause: #170 was made from a branch in this repo and had the "duplicate" CI.

Oh, I did not realise, I used the builtin editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants