-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove coverity from the DevGuide #1411
Conversation
development-tools/clang.rst
Outdated
@@ -54,7 +54,7 @@ A complete list of sanitizers can be found at `Controlling Code Generation | |||
|
|||
Clang and its sanitizers have strengths (and weaknesses). Its just one tool in | |||
the war chest to uncovering bugs and improving code quality. Clang should be | |||
used to complement other methods, including Code Reviews, Valgrind, Coverity, | |||
used to complement other methods, including Code Reviews, Valgrind, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, do we have more info about "Valgrind"? It was mentioned only once on the entire devguide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to use valgrind? What is it for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valgrind is a tool for finding C-level memory issues, like memory leaks or writes to uninitialized memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's documented here: https://github.com/python/cpython/blob/main/Misc/README.valgrind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, we also have a https://github.com/python/cpython/blob/main/Misc/README.coverity that perhaps should be cleaned up from the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I found references to coverity on the CPython repo. In addition to README.coverity,
also Misc\coverity_model.c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's documented here: https://github.com/python/cpython/blob/main/Misc/README.valgrind
I updated to link to that doc. Thanks.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Related CPython PR: python/cpython#124460 |
Thanks! |
The CPython Coverity Scan hasn't been updated since 2020.
People listed as admins and experts of coverity scan are no longer administering/maintaining it.
On Discord, it was decided to drop this from CPython core workflow.
Closes #1410
📚 Documentation preview 📚: https://cpython-devguide--1411.org.readthedocs.build/