Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to quay.io/tiran/cpython_autoconf #1236

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Dec 4, 2023

The make regen-configure does the right thing via containers already.


📚 Documentation preview 📚: https://cpython-devguide--1236.org.readthedocs.build/

The `make regen-configure` does the right thing via containers already.
@brettcannon brettcannon self-assigned this Dec 4, 2023
@encukou
Copy link
Member

encukou commented Dec 5, 2023

My devguide experience with documenting only the make command is that it hurts Windows users. Is this already unusable on Windows? (I don't think you'd want to tweak configure there, but perhaps fix up someone else's commit?)

And in this case, the command would also be useful if you have yet another kind of container tooling.

@erlend-aasland
Copy link
Contributor

Windows users do not use configure; they use their own custom build script.

@brettcannon brettcannon merged commit 4d757d2 into python:main Dec 5, 2023
3 checks passed
@brettcannon
Copy link
Member Author

My devguide experience with documenting only the make command is that it hurts Windows users. Is this already unusable on Windows? (I don't think you'd want to tweak configure there, but perhaps fix up someone else's commit?)

And in this case, the command would also be useful if you have yet another kind of container tooling.

Windows developers can always use a GitHub Codespace if they needed a way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants