Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve C API guidelines for return values #1129

Closed
wants to merge 6 commits into from
Closed

Improve C API guidelines for return values #1129

wants to merge 6 commits into from

Commits on Jun 26, 2023

  1. Improve C API guidelines for return values 

    Clarify that returning an error indicator should be done iff an
exception is raised.

For functions returning an int, a _negative value_ should be returned.
Suggest -1 unless there is a need to distinguish between error types.
    @erlend-aasland
    erlend-aasland committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ba7ce7b View commit details
    Browse the repository at this point in the history

  2. Commas

    @erlend-aasland
    erlend-aasland committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    d45cfd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
    @erlend-aasland @AA-Turner
    erlend-aasland and AA-Turner authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    01335f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Update developer-workflow/c-api.rst 

    Co-authored-by: Petr Viktorin <encukou@gmail.com>
    @erlend-aasland @encukou
    erlend-aasland and encukou authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    b045b03 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Update developer-workflow/c-api.rst

    @erlend-aasland
    erlend-aasland authored Sep 6, 2023
    Configuration menu
    Copy the full SHA
    95b5951 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Update developer-workflow/c-api.rst 

    Co-authored-by: Victor Stinner <vstinner@python.org>
    @erlend-aasland @vstinner
    erlend-aasland and vstinner authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8049811 View commit details
    Browse the repository at this point in the history