-
-
Notifications
You must be signed in to change notification settings - Fork 851
Use Wayback Machine link for defunct Victor Stinner's guide #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following commit authors need to sign the Contributor License Agreement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now, thanks @Dev-satish
@Dev-satish Could you sign the CLA? This is a fairly trivial change, but it just takes a second to sign the CLA, and it only needs to be done once. |
@@ -314,7 +314,7 @@ You can run the build of Python you've compiled with: | |||
See the `PCBuild readme`_ for more details on what other software is necessary | |||
and how to build. | |||
|
|||
.. _Victor Stinner's guide: https://cpython-core-tutorial.readthedocs.io/en/latest/build_cpython_windows.html | |||
.. _Victor Stinner's guide: https://web.archive.org/web/20220907075854/https://cpython-core-tutorial.readthedocs.io/en/latest/build_cpython_windows.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using https://github.com/vstinner/cpython_core_tutorial/blob/main/build_cpython_windows.rst is also an option.
Eventually I think it would be better to improve the Windows building instruction in the devguide and remove the link to Victor's tutorial.
In the meanwhile, using the archive.org link is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes correct, i asked this and i was advised to go with the archived one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually I think it would be better to improve the Windows building instruction in the devguide and remove the link to Victor's tutorial.
In the meanwhile, using the archive.org link is ok.
Yeah, agreed, and seems Steve Dower had similar thoughts in his comments on my previous PR that I linked in the issue
The notification is likely to be stuck because Since GitHub will be unable to send a verification mail to this private domain, you need to recreate your commit using any email address specified on that settings page (if you don't want to show your primary one, you can add and use another that can receive letters from the outside). For recreation of the commit, you can change email in settings of your Git client (the instructions are client-dependend but can be found in Google), force-reset the |
For history: the fixed PR is gh-1050. |
And for future reference, you could also have just reset and force-pushed the branch here (as @arhadthedev mentioned here, and I believe others did in #1048 as well), and not needed to create a whole new PR. |
Changes
I've changed the link for the Victor Stinner's guide.
File: getting-started/setup-building.rst
Line : 317