Skip to content

Use Wayback Machine link for defunct Victor Stinner's guide #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Dev-satish
Copy link
Contributor

Changes

I've changed the link for the Victor Stinner's guide.

File: getting-started/setup-building.rst
Line : 317

@ghost
Copy link

ghost commented Feb 9, 2023

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@Dev-satish Dev-satish changed the title gh-1044 Fixing Victor Stinner’s guide has broken link in documentation #gh-1044 Fixing Victor Stinner’s guide has broken link in documentation Feb 9, 2023
@Dev-satish Dev-satish changed the title #gh-1044 Fixing Victor Stinner’s guide has broken link in documentation gh-1044 Fixing Victor Stinner’s guide has broken link in documentation Feb 9, 2023
@CAM-Gerlach CAM-Gerlach changed the title gh-1044 Fixing Victor Stinner’s guide has broken link in documentation Use Wayback Machine link for defunct Victor Stinner's guide Feb 10, 2023
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now, thanks @Dev-satish

@CAM-Gerlach
Copy link
Member

@Dev-satish Could you sign the CLA? This is a fairly trivial change, but it just takes a second to sign the CLA, and it only needs to be done once.

@@ -314,7 +314,7 @@ You can run the build of Python you've compiled with:
See the `PCBuild readme`_ for more details on what other software is necessary
and how to build.

.. _Victor Stinner's guide: https://cpython-core-tutorial.readthedocs.io/en/latest/build_cpython_windows.html
.. _Victor Stinner's guide: https://web.archive.org/web/20220907075854/https://cpython-core-tutorial.readthedocs.io/en/latest/build_cpython_windows.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using https://github.com/vstinner/cpython_core_tutorial/blob/main/build_cpython_windows.rst is also an option.
Eventually I think it would be better to improve the Windows building instruction in the devguide and remove the link to Victor's tutorial.
In the meanwhile, using the archive.org link is ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct, i asked this and i was advised to go with the archived one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually I think it would be better to improve the Windows building instruction in the devguide and remove the link to Victor's tutorial.
In the meanwhile, using the archive.org link is ok.

Yeah, agreed, and seems Steve Dower had similar thoughts in his comments on my previous PR that I linked in the issue

@arhadthedev
Copy link
Member

The following commit authors need to sign the Contributor License Agreement

The notification is likely to be stuck because dev_satish@Satish.localdomain is not added into your profile settings (https://github.com/settings/emails).

Since GitHub will be unable to send a verification mail to this private domain, you need to recreate your commit using any email address specified on that settings page (if you don't want to show your primary one, you can add and use another that can receive letters from the outside).

For recreation of the commit, you can change email in settings of your Git client (the instructions are client-dependend but can be found in Google), force-reset the fixingvictorstinnersguidelink branch onto main, create the commit anew and force-push it.

@Dev-satish Dev-satish closed this Feb 10, 2023
@Dev-satish Dev-satish deleted the fixingvictorstinnersguidelink branch February 10, 2023 12:01
@arhadthedev
Copy link
Member

For history: the fixed PR is gh-1050.

@CAM-Gerlach
Copy link
Member

And for future reference, you could also have just reset and force-pushed the branch here (as @arhadthedev mentioned here, and I believe others did in #1048 as well), and not needed to create a whole new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants