-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35024: Remove redundant and possibly incorrect verbose message after writing '.pyc' #9998
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
The commit needs a "make regen-importlib" before the tests will run. |
I've just learnt about Another question (please let me know if it's not the place to seek for such advice I don't want to waste your time): do I rebase this branch on top of |
For review purposes, merging master into the PR branch is better (since GitHub does a better job of figuring out the appropriate diff with earlier versions of the review PR). There's then a final squash & merge at commit time that avoids complicating the development history with those additional merges. |
Thanks. Merged master, ran |
Just for reference, the main logging call is handled by: cpython/Lib/importlib/_bootstrap_external.py Lines 1033 to 1039 in 4e3a53b
I've left comments on the issue to discuss a potential alternative solution. |
Actually, my alternative is unnecessarily complex. 😄 I tweaked the news entry, so once CI goes green this will be merged. |
😊 proud of my first non-typo-fixing contribution. Next step: try to add a line of code 😅 |
@qagren: Status check is done, and it's a success ✅ . |
@qagren honestly, code removal is more important than adding. Less code (typically) means less maintenance. When we started Python 3.0 we had an informal competition over who could remove the most amount of code from the stdlib. 😄 |
Since
SourceFileLoader.set_data()
catches exceptions raised by_write_atomic()
and logs an informative message consequently, always logging successful outcome in 'SourceLoader.get_code()' seems redundant.https://bugs.python.org/issue35024