Skip to content

gh-99387: Update pathlib.Path.absolute() docs to add versionadded #99416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Reddragonemperor58
Copy link

#99387: committed changes to tech documentation under the path.absolute() function

@ghost
Copy link

ghost commented Nov 12, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 12, 2022
@@ -1217,6 +1217,8 @@ call fails (for example because the path doesn't exist).
>>> p.absolute()
PosixPath('/home/antoine/pathlib/tests')

.. versionadded:: 3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. versionadded:: 3.11
.. versionadded:: 3.4

But per Brandt, this likely isn't needed at all.

A

Copy link
Author

@Reddragonemperor58 Reddragonemperor58 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah my bad I was committing changes when he posted and I didn't see that but still
@AA-Turner isn't it 3.11?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is marked as resolved, though you haven't pushed the change yet -- is this intentional?

A

Copy link
Author

@Reddragonemperor58 Reddragonemperor58 Nov 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No i didn't understand the term!
i just clicked on it and was waiting for your reply then I saw it was changed to unresolved;😅
and the resolved thing was trailing whitespaces

@Reddragonemperor58 Reddragonemperor58 changed the title Updated tech docs as per issue #99387 gh-99387 Updated tech docs as per issue Nov 12, 2022
@tudortimi
Copy link

@AA-Turner IMO, kind of strange to mark it as "added in 3.4", since pathlib itself was added in 3.4. The philosophical issue in #99387 remains.

@brettcannon brettcannon changed the title gh-99387 Updated tech docs as per issue gh-99387: Update pathlib.Path.absolute() docs to add versionadded Nov 15, 2022
@brettcannon
Copy link
Member

The decision in the issue is to not make any changes. Thanks anyway for the PR, @Reddragonemperor58 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants