gh-99238: Fix crashes caused by lack of checking in subprocess module #99239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
Sometimes application developers set the value of an environment variable to None. This fix adds a guard for mitigating this issue to prevent python from crashing. Signed-off-by: Tianrui Wei <tianrui@tianruiwei.com>
tianrui-wei
force-pushed
the
fix-issue-99238
branch
from
e2e5421 to
7f3ccdb
Compare
Member
|
environment dicts are str to str or a bytes to bytes mapping, they cannot contain None values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes application developers set the value of an environment variable to None. This fix adds a guard for mitigating this issue to prevent python from crashing.
Signed-off-by: Tianrui Wei tianrui@tianruiwei.com