-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-81057: Move the Allocators to _PyRuntimeState #99217
Merged
ericsnowcurrently
merged 19 commits into
python:main
from
ericsnowcurrently:move-allocators-to-runtime-state
Nov 11, 2022
Merged
gh-81057: Move the Allocators to _PyRuntimeState #99217
ericsnowcurrently
merged 19 commits into
python:main
from
ericsnowcurrently:move-allocators-to-runtime-state
Nov 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124ad70
to
02256e9
Compare
9ab2bfc
to
edcd287
Compare
edcd287
to
aa8c9cb
Compare
aa8c9cb
to
3172cbe
Compare
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5262207 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global allocators were stored in 3 static global variables:
_PyMem_Raw
,_PyMem
, and_PyObject
. State for the "small block" allocator was stored in another 13. That makes a total of 16 global variables. We are moving all 16 to the_PyRuntimeState
struct as part of the work for gh-81057. (If PEP 684 is accepted then we will follow up by moving them all toPyInterpreterState
.)