GH-99104: Update headers for bytecodes.c and generate_cases.py #99112
Conversation
Also tweak the labels near the end of bytecodes.c.
| // Note that there is some dummy C code at the top and bottom of the file | ||
| // to fool text editors like VS Code into believing this is valid C code. | ||
| // The actual instruction definitions start at // BEGIN BYTECODES //. |
There was a problem hiding this comment.
Nitpick: It's really the top and middle of this file. Might be worth mentioning the // Families go below this point // section, too.
There was a problem hiding this comment.
I'd like to leave finding that as an exercise for the reader, since that is work in progress. The generator currently doesn't actually see the families because it stops reading after // END BYTECODES // -- I was planning to fix that once families are actually used for anything.
| resume_with_error: | ||
| start_frame: | ||
| unbound_local_error: | ||
| ; |
There was a problem hiding this comment.
Is this semicolon really needed? My IDE (VS Code) doesn't complain...
There was a problem hiding this comment.
It's an error to real C compilers, so better safe than sorry.
|
That's weird. Does the test runner really return |
| // Note that there is some dummy C code at the top and bottom of the file | ||
| // to fool text editors like VS Code into believing this is valid C code. | ||
| // The actual instruction definitions start at // BEGIN BYTECODES //. |
There was a problem hiding this comment.
I'd like to leave finding that as an exercise for the reader, since that is work in progress. The generator currently doesn't actually see the families because it stops reading after // END BYTECODES // -- I was planning to fix that once families are actually used for anything.
| resume_with_error: | ||
| start_frame: | ||
| unbound_local_error: | ||
| ; |
There was a problem hiding this comment.
It's an error to real C compilers, so better safe than sorry.
Also tweak the labels near the end of bytecodes.c.
This is also part of GH-98831.