bpo-34987: Fix a possible null pointer dereference in _pickle.c's save_reduce() #9886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Nov 8, 2018
serhiy-storchaka
added
skip news
needs backport to 3.6
type-bug
Modules/_pickle.c
Outdated
| @@ -3840,6 +3840,9 @@ save_reduce(PicklerObject *self, PyObject *args, PyObject *obj) | |||
|
|
|||
| if (obj != NULL) { | |||
| obj_class = get_class(obj); | |||
| if (obj_class == NULL) { | |||
| return -1; | |||
| } | |||
| p = obj_class != cls; /* true iff a problem */ | |||
There was a problem hiding this comment.
Suggested change
| p = obj_class != cls; /* true iff a problem */ | |
| p = obj_class != cls; |
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-10932 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…e_reduce(). (pythonGH-9886) (cherry picked from commit 25d3897) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
|
GH-10933 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…e_reduce(). (pythonGH-9886) (cherry picked from commit 25d3897) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34987