-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-98576: Fix types in dataclass.InitVar example #98577
Conversation
hauntsaninja
commented
Oct 23, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Example in dataclass documentation is incorrectly typed #98576
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ericvsmith, are you okay with this change? :) It brings the example in the |
Thanks @hauntsaninja for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry @hauntsaninja and @ericvsmith, I had trouble checking out the |
(cherry picked from commit 880bafc) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
GH-98909 is a backport of this pull request to the 3.10 branch. |
Looks good. Thanks! Does someone want to look at the 3.11 merge conflict? |
Thanks @hauntsaninja for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
(cherry picked from commit 880bafc) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
GH-98910 is a backport of this pull request to the 3.11 branch. |
There was no merge conflict; just some sort of race condition that meant that @miss-islington was unable to check out the 3.11 branch. She succeeded on the second attempt :) |
Thanks! |
@AlexWaygood where did you see the missislington logs? If you link me, I could take a look at fixing it :-) |
It's just the posted message I think. I recently improved the message in python/miss-islington@868b6ba; from there it may be possible to trace the code to figure out the actual bug. This condition most frequently happens when trying to do multiple backports at once, like on this PR, which makes me think it may be a race condition where both backports try to use the same resource. However, I've also seen it happen on PRs that were backported only to a single branch. |
Yes — to be clear, I don't have solid confirmation that a race condition is to blame; that's just my suspicion, given that removing and re-adding the label almost always seems to work :) |