Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98461: Fix location of RETURN_VALUE in async generator bytecode. compiler_jump_if no longer needs a pointer to the loc. #98494

Merged
merged 1 commit into from
Oct 25, 2022
Merged

gh-98461: Fix location of RETURN_VALUE in async generator bytecode. compiler_jump_if no longer needs a pointer to the loc. #98494

merged 1 commit into from
Oct 25, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 20, 2022 •
edited by bedevere-bot
Loading

The location of RETURN_VALUE in the test I committed earlier was incorrect. Fixed here, plus some cleanup.

@iritkatriel
pythongh-98461: Fix location of RETURN_VALUE in async generator bytec…
ae7c59d 
…ode. compiler_jump_if no longer needs a pointer to the loc
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Oct 20, 2022
markshannon
markshannon approved these changes Oct 25, 2022
View reviewed changes
@iritkatriel iritkatriel merged commit a1a8828 into python:main Oct 25, 2022
@iritkatriel iritkatriel deleted the jump_if_ploc branch July 25, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iritkatriel @markshannon @bedevere-bot