Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-97607: Fix content parsing in the impl-detail reST directive (GH-97652) #97723

Merged
merged 1 commit into from
Oct 2, 2022
Merged

[3.11] gh-97607: Fix content parsing in the impl-detail reST directive (GH-97652) #97723

merged 1 commit into from
Oct 2, 2022

Commits on Oct 2, 2022

  1. pythongh-97607: Fix content parsing in the impl-detail reST directive (… 

    …pythonGH-97652)

* Don't parse content as arg in the impl-detail directive

This does not change the (untranslated) output,
but ensures that the doctree node metadata is correct.
which fixes pythongh-97607 with the text not being translated.
It also simplifies the code and logic
and makes it consistant with the docutils built-in directives.

* Remove unused branch from impl-detail directive handling no-content case

This is not used anywhere in the docs and lacks a clear use case,
and is more likely a mistake which is now flagged at build time.
This simplifies the logic from two code paths to one,
and makes the behavior consistant with similar built-in directives
(e.g. the various admonition types).

* Further simplify impl-detail reST directive code
(cherry picked from commit e8165d4)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
    @CAM-Gerlach @miss-islington
    CAM-Gerlach authored and miss-islington committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    8ca39d5 View commit details
    Browse the repository at this point in the history