-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95913: Move py.exe to appropriate What's New section & refine text #97718
Merged
ezio-melotti
merged 5 commits into
python:main
from
CAM-Gerlach:whatsnew-move-win-launcher-section
Oct 4, 2022
Merged
gh-95913: Move py.exe to appropriate What's New section & refine text #97718
ezio-melotti
merged 5 commits into
python:main
from
CAM-Gerlach:whatsnew-move-win-launcher-section
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
ezio-melotti
reviewed
Oct 3, 2022
I approve whatever you decide to do here. No strong opinions |
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti
approved these changes
Oct 4, 2022
Thanks @CAM-Gerlach for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-97853 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 4, 2022
…e text (pythonGH-97718) * Move Windows py.exe improvements from Typing section to New Features * Add ref target label and use literal for py.exe * Be clearer/explict about what legacy version arg components reprisent * Apply other minor clarity and textual fixes to py.exe launcher text * Refine phrasing of legacy sentence of py.exe desc Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 9859581) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington
added a commit
that referenced
this pull request
Oct 4, 2022
…GH-97718) * Move Windows py.exe improvements from Typing section to New Features * Add ref target label and use literal for py.exe * Be clearer/explict about what legacy version arg components reprisent * Apply other minor clarity and textual fixes to py.exe launcher text * Refine phrasing of legacy sentence of py.exe desc Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 9859581) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
…e text (python#97718) * Move Windows py.exe improvements from Typing section to New Features * Add ref target label and use literal for py.exe * Be clearer/explict about what legacy version arg components reprisent * Apply other minor clarity and textual fixes to py.exe launcher text * Refine phrasing of legacy sentence of py.exe desc Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
…GH-97718) * Move Windows py.exe improvements from Typing section to New Features * Add ref target label and use literal for py.exe * Be clearer/explict about what legacy version arg components reprisent * Apply other minor clarity and textual fixes to py.exe launcher text * Refine phrasing of legacy sentence of py.exe desc Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 9859581) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #95913
Discussion of the improvements to the
py.exe
Windows launcher was mistakenly added to the "New Features Related to Type Hints" section of the What's New in #96595 , which clearly doesn't seem to be the right place. I moved it to what seemed to be the most appropriate existing section, New Features (since there wasn't a section specific to ancillary utilities or Windows-specific changes, and I didn't want to introduce a whole new section just for it especially at this late hour, and because that was the most likely section it was intended to go under).In addition, I made some minor refinements to the text/syntax consistent with the other What's New changes, including:
-ZZ
)py.exe
, consistent with general convention and its specific usage elsewhere