Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95913: Move py.exe to appropriate What's New section & refine text #97718

Merged

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Oct 2, 2022

Part of #95913

Discussion of the improvements to the py.exe Windows launcher was mistakenly added to the "New Features Related to Type Hints" section of the What's New in #96595 , which clearly doesn't seem to be the right place. I moved it to what seemed to be the most appropriate existing section, New Features (since there wasn't a section specific to ancillary utilities or Windows-specific changes, and I didn't want to introduce a whole new section just for it especially at this late hour, and because that was the most likely section it was intended to go under).

In addition, I made some minor refinements to the text/syntax consistent with the other What's New changes, including:

  • Be more explicit to clarify what the legacy version arg components represent, as I was initially somewhat confused (especially on -ZZ)
  • Add a ref target label and using a literal for py.exe, consistent with general convention and its specific usage elsewhere
  • Apply other minor grammar, clarity and readability fixes

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 2, 2022
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes OS-windows labels Oct 2, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 2, 2022
33 tasks
@zooba
Copy link
Member

zooba commented Oct 4, 2022

I approve whatever you decide to do here. No strong opinions

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@ezio-melotti ezio-melotti merged commit 9859581 into python:main Oct 4, 2022
@miss-islington
Copy link
Contributor

Thanks @CAM-Gerlach for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97853 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2022
…e text (pythonGH-97718)

* Move Windows py.exe improvements from Typing section to New Features

* Add ref target label and use literal for py.exe

* Be clearer/explict about what legacy version arg components reprisent

* Apply other minor clarity and textual fixes to py.exe launcher text

* Refine phrasing of legacy sentence of py.exe desc

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 9859581)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington added a commit that referenced this pull request Oct 4, 2022
…GH-97718)

* Move Windows py.exe improvements from Typing section to New Features

* Add ref target label and use literal for py.exe

* Be clearer/explict about what legacy version arg components reprisent

* Apply other minor clarity and textual fixes to py.exe launcher text

* Refine phrasing of legacy sentence of py.exe desc

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 9859581)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
…e text (python#97718)

* Move Windows py.exe improvements from Typing section to New Features

* Add ref target label and use literal for py.exe

* Be clearer/explict about what legacy version arg components reprisent

* Apply other minor clarity and textual fixes to py.exe launcher text

* Refine phrasing of legacy sentence of py.exe desc

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
…GH-97718)

* Move Windows py.exe improvements from Typing section to New Features

* Add ref target label and use literal for py.exe

* Be clearer/explict about what legacy version arg components reprisent

* Apply other minor clarity and textual fixes to py.exe launcher text

* Refine phrasing of legacy sentence of py.exe desc

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
(cherry picked from commit 9859581)

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes docs Documentation in the Doc dir OS-windows skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants