Skip to content

bpo-34922: Fixed integer overflow in the digest() and hexdigest() methods #9751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Oct 11, 2018
Merged

bpo-34922: Fixed integer overflow in the digest() and hexdigest() methods #9751

serhiy-storchaka merged 1 commit into from
Oct 11, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 7, 2018 •
edited by bedevere-bot
Loading

for the SHAKE algorithm in the hashlib module.

https://bugs.python.org/issue34922

@serhiy-storchaka
bpo-34922: Fixed integer overflow in the digest() and hexdigest() met…
8e692bb 
…hods

for the SHAKE algorithm in the hashlib module.
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Oct 7, 2018
@ned-deily
Copy link
Member

ned-deily commented Oct 7, 2018

@serhiy-storchaka, I'm not interested in a change for master as there is no rush for that so I'm removing myself as a reviewer. I'll let you all figure out what's best. My concern is for 3.6 where something is needed and for 3.7. Is a change like this needed for 3.7 as long as PR 8581 remains in 3.7?

@ned-deily ned-deily removed their request for review October 7, 2018 19:13
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Oct 7, 2018

A change like this is needed for 3.7 in any case, independently from the fate of #8581. Just crashes can be caused by different input values.

@serhiy-storchaka serhiy-storchaka merged commit 9b8c2e7 into python:master Oct 11, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@serhiy-storchaka serhiy-storchaka deleted the hashlib-digest-overflow branch October 11, 2018 04:41
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9b8c2e767643256202bb11456ba8665593b9a500 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2018
@serhiy-storchaka @miss-islington
bpo-34922: Fix integer overflow in the digest() and hexdigest() metho…
6c5d06a 
…ds (pythonGH-9751)

for the SHAKE algorithm in the hashlib module.
(cherry picked from commit 9b8c2e7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2018

GH-9797 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 11, 2018
@serhiy-storchaka
[3.7] bpo-34922: Fix integer overflow in the digest() and hexdigest()…
4b363b9 
… methods (pythonGH-9751)

for the SHAKE algorithm in the hashlib module..
(cherry picked from commit 9b8c2e7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2018

GH-9798 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request Oct 11, 2018
@serhiy-storchaka
[3.7] bpo-34922: Fix integer overflow in the digest() and hexdigest()…
8b040e5 
… methods (GH-9751) (GH-9798)

for the SHAKE algorithm in the hashlib module.
(cherry picked from commit 9b8c2e7)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2018
@serhiy-storchaka @miss-islington
[3.7] bpo-34922: Fix integer overflow in the digest() and hexdigest()…
ffec90b 
… methods (pythonGH-9751) (pythonGH-9798)

for the SHAKE algorithm in the hashlib module.
(cherry picked from commit 9b8c2e7)
(cherry picked from commit 8b040e5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Oct 11, 2018

GH-9801 is a backport of this pull request to the 3.6 branch.

@serhiy-storchaka serhiy-storchaka removed their assignment Oct 11, 2018
serhiy-storchaka added a commit that referenced this pull request Oct 11, 2018
@miss-islington @serhiy-storchaka
[3.6] bpo-34922: Fix integer overflow in the digest() and hexdigest()…
69e6ad6 
… methods (GH-9751) (GH-9798) (GH-9801)

for the SHAKE algorithm in the hashlib module.
(cherry picked from commit 9b8c2e7)
(cherry picked from commit 8b040e5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @ned-deily @miss-islington @bedevere-bot @the-knights-who-say-ni