Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34897: distutils test errors when CXX is not set #9706

Merged
merged 6 commits into from
Dec 26, 2018
Merged

bpo-34897: distutils test errors when CXX is not set #9706

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6754e25
Fix Lib/distutils/ccompiler.py def set_executables() so that {key:val…
aixtools Oct 4, 2018
7692e93
Fix News to pass Docs test
aixtools Oct 11, 2018
e66868e
set value to None rather than 'null string'
aixtools Oct 30, 2018
596f213
Fix the test rather than the assignment in ccompiler.py
aixtools Nov 5, 2018
269d62b
Update blurb
aixtools Nov 5, 2018
d3905e5
Reword NEWS entry
ncoghlan Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
set value to None rather than 'null string'
  • Loading branch information
@aixtools
aixtools committed Oct 30, 2018
commit e66868ecfebee2e355c4193686b37466f58df28e
6 changes: 1 addition & 5 deletions Lib/distutils/ccompiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,7 @@ class (via the 'executables' class attribute), but most will have:
if key not in self.executables:
raise ValueError("unknown executable '%s' for class %s" %
(key, self.__class__.__name__))
if kwargs[key]:
v = kwargs[key] if len(kwargs[key].strip()) else None
else:
v = None
self.set_executable(key, v)
self.set_executable(key, kwargs[key] or None)

def set_executable(self, key, value):
if isinstance(value, str):
Expand Down