gh-96954: Add tests for unicodedata.name/lookup #96955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were undertested, and since python#96954 might involve a rewrite of this part of the code we want to ensure that there won't be any behavioral change. Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
ambv
added
needs backport to 3.10
Contributor
|
Thanks @isidentical for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Contributor
|
Thanks @isidentical for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
|
Sorry, @isidentical and @ambv, I could not cleanly backport this to |
Contributor
|
Sorry @isidentical and @ambv, I had trouble checking out the |
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Sep 21, 2022
…H-96955) They were undertested, and since pythonGH-96954 might involve a rewrite of this part of the code we want to ensure that there won't be any behavioral change. Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de> (cherry picked from commit 5a32eec) Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
|
GH-96991 is a backport of this pull request to the 3.11 branch. |
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Sep 21, 2022
…H-96955) They were undertested, and since pythonGH-96954 might involve a rewrite of this part of the code we want to ensure that there won't be any behavioral change. Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de> (cherry picked from commit 5a32eec) Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
|
GH-96992 is a backport of this pull request to the 3.10 branch. |
ambv
pushed a commit
that referenced
this pull request
Sep 21, 2022
They were undertested, and since GH-96954 might involve a rewrite of this part of the code we want to ensure that there won't be any behavioral change. Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de> (cherry picked from commit 5a32eec) Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
ambv
added a commit
that referenced
this pull request
Sep 21, 2022
…-96992) They were undertested, and since GH-96954 might involve a rewrite of this part of the code we want to ensure that there won't be any behavioral change. Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de> (cherry picked from commit 5a32eec) Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
ambv
added a commit
that referenced
this pull request
Sep 21, 2022
…-96991) They were undertested, and since GH-96954 might involve a rewrite of this part of the code we want to ensure that there won't be any behavioral change. Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de> (cherry picked from commit 5a32eec) Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were undertested, and since #96954 might involve a rewrite of this part of the code we want to ensure that there won't be any behavioral change.
Co-authored-by: Carl Friedrich Bolz-Tereick cfbolz@gmx.de