-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96821: Fix undefined behaviour in audioop.c
#96923
Merged
mdickinson
merged 11 commits into
python:main
from
matthiasgoergens:matthias/fix-audioop-UB
Oct 10, 2022
Merged
gh-96821: Fix undefined behaviour in audioop.c
#96923
mdickinson
merged 11 commits into
python:main
from
matthiasgoergens:matthias/fix-audioop-UB
Oct 10, 2022
Commits on Sep 19, 2022
-
pythongh-96821: Fix undefined behaviour in
audioop.c
Left-shifting negative numbers is undefined behaviour. Fortunately, multiplication works just as well, is defined behaviour, and gets compiled to the same machine code as before by optimizing compilers.
Configuration menu - View commit details
-
Copy full SHA for 13b5850 - Browse repository at this point
Copy the full SHA 13b5850View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07d709a - Browse repository at this point
Copy the full SHA 07d709aView commit details
Commits on Sep 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fd6f822 - Browse repository at this point
Copy the full SHA fd6f822View commit details
Commits on Sep 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a3502da - Browse repository at this point
Copy the full SHA a3502daView commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 98b2352 - Browse repository at this point
Copy the full SHA 98b2352View commit details
Commits on Oct 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c549094 - Browse repository at this point
Copy the full SHA c549094View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15e43a6 - Browse repository at this point
Copy the full SHA 15e43a6View commit details
Commits on Oct 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4e36000 - Browse repository at this point
Copy the full SHA 4e36000View commit details
Commits on Oct 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c3f9108 - Browse repository at this point
Copy the full SHA c3f9108View commit details -
Configuration menu - View commit details
-
Copy full SHA for da7aab3 - Browse repository at this point
Copy the full SHA da7aab3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba80611 - Browse repository at this point
Copy the full SHA ba80611View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.