Make it clear that the msg argument to assertWarns/assertWarnsRegex/assertRaisesRegex is keyword-only. #9680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssertRaisesRegex is keyword-only. A follow up to be4e5b8.
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-9681 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 3, 2018
…ssertRaisesRegex is keyword-only. (pythonGH-9680) A follow up to be4e5b8. (cherry picked from commit e006b39) Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 3, 2018
…ssertRaisesRegex is keyword-only. (pythonGH-9680) A follow up to be4e5b8. (cherry picked from commit e006b39) Co-authored-by: Benjamin Peterson <benjamin@python.org>
|
GH-9682 is a backport of this pull request to the 3.6 branch. |
ned-deily
pushed a commit
that referenced
this pull request
Oct 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to be4e5b8.