Skip to content

Make it clear that the msg argument to assertRaises is keyword-only. #9670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2018
Merged

Make it clear that the msg argument to assertRaises is keyword-only. #9670

merged 1 commit into from
Oct 2, 2018

Conversation

benjaminp
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Oct 2, 2018
@benjaminp benjaminp merged commit be4e5b8 into python:master Oct 2, 2018
@miss-islington
Copy link
Contributor

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@benjaminp benjaminp deleted the assert-raises-keyword branch October 2, 2018 05:18
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2018
@benjaminp @miss-islington
Make it clear that the msg argument to assertRaises is keyword-only. (p…
0d032a8 
…ythonGH-9670)

(cherry picked from commit be4e5b8)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link

GH-9671 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2018
@benjaminp @miss-islington
Make it clear that the msg argument to assertRaises is keyword-only. (p…
944c2e1 
…ythonGH-9670)

(cherry picked from commit be4e5b8)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link

GH-9672 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Oct 2, 2018
@miss-islington @benjaminp
Make it clear that the msg argument to assertRaises is keyword-only. (G…
484c899 
…H-9670)

(cherry picked from commit be4e5b8)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington added a commit that referenced this pull request Oct 2, 2018
@miss-islington @benjaminp
Make it clear that the msg argument to assertRaises is keyword-only. (G…
58376c6 
…H-9670)

(cherry picked from commit be4e5b8)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@serhiy-storchaka
Copy link
Member

See also assertRaisesRegex(), assertWarns() and assertWarnsRegex(). And maybe other methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benjaminp @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni