GH-46412: More efficient bool() for ndbm/_gdbmmodule #96692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on patches uploaded to BPO by BPO user eolson (Eric Olson). No known email or GitHub username for attribution. (The bug was opened in 2008, not quite a record but still impressive.)
|
There was a subtle indentation error that caused 'make patchcheck' to fail. Also, 'test_int' is now flaky due to the int-conversion security check -- it checks the time it takes to do conversions and the Azure VM was too slow. We may need to discuss this on Discord. |
Ooops, I didn't notice that. |
|
Neither did I -- it took me forever (firing up various tools) to notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on patches uploaded to BPO by BPO user eolson (Eric Olson).
No known email or GitHub username for attribution.
(The bug was opened in 2008, not quite a record but still impressive.)