Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34476: Document that asyncio.sleep() always suspends. #9643

Merged
merged 2 commits into from
Oct 1, 2018
Merged

bpo-34476: Document that asyncio.sleep() always suspends. #9643

merged 2 commits into from
Oct 1, 2018

Conversation

hniksic
Copy link
Contributor

@hniksic hniksic commented Sep 30, 2018 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 30, 2018
asvetlov
asvetlov requested changes Sep 30, 2018
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hniksic
Copy link
Contributor Author

hniksic commented Sep 30, 2018

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@asvetlov asvetlov merged commit cd602b8 into python:master Oct 1, 2018
@miss-islington
Copy link
Contributor

Thanks @hniksic for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2018
@hniksic @miss-islington
bpo-34476: Document that asyncio.sleep() always suspends. (pythonGH-9643
43a3848 
)

(cherry picked from commit cd602b8)

Co-authored-by: Hrvoje Nikšić <hniksic@gmail.com>
@bedevere-bot
Copy link

GH-9654 is a backport of this pull request to the 3.7 branch.

@asvetlov
Copy link
Contributor

asvetlov commented Oct 1, 2018

@hniksic thank you for your patience.

asvetlov pushed a commit that referenced this pull request Oct 1, 2018
@miss-islington @hniksic @asvetlov
bpo-34476: Document that asyncio.sleep() always suspends. (GH-9643) (#…
655608a 
…9654)

(cherry picked from commit cd602b8)

Co-authored-by: Hrvoje Nikšić <hniksic@gmail.com>
@hniksic
Copy link
Contributor Author

hniksic commented Oct 1, 2018

@asvetlov No problem, thanks for the quick reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hniksic @the-knights-who-say-ni @bedevere-bot @miss-islington @asvetlov @1st1