-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update download.html to reflect the unit change #9639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@JulienPalard: Would you mind to review this PR? |
@JulienPalard could you take a look at this? |
An alternative is to remove the download sizes. I don't expect that release managers update this page as part of the release process: |
I also think that documentation size isn't that important nowadays, but perhaps there's a rationale we are missing here? |
@andresdelfino there are regions here in germany where people only get very slow internet connections. So it makes a difference for them if it is 1 MB or 5 MB. But they might not be python developers... |
@vstinner how should I proceed? Should I remove the file sizes or preserve them and fix the typo pointed by Serhiy? |
@andresdelfino: Honestly, I'm very confused by this issue. I don't understand why it takes months to fix such trivial issue :-) I skip my turn and let others handle it, sorry :-( |
With the commit of @vstinner (see 8c663fd#diff-9c9d6c705ef5234b89019a8310a89d21), we don't need to specify the unit because it's explicitly indicated in the table. Moreover, the commit removes the ambiguity with the unit. The best thing to do is removing the complete line with the detailed unit. I am going to close your PR and will fix the line. Thank you a lot for your PR and hope to see your next contributions in the future. PS: Before closing this issue, I have discussed with @JulienPalard about this issue. |
@matrixise thanks for the reply :) |
@matrixise: Would you mind to add a link to your fix here? |
See #4293.