Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34843: Remove recent from logging cookbook #9636

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Sep 29, 2018

Remove the word 'recent' when referring to multiprocessing in the logging cookbook.

https://bugs.python.org/issue34843

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 29, 2018
@rhettinger rhettinger self-assigned this Oct 1, 2018
Copy link
Contributor

@rhettinger rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only change the "If you are using a recent version of Python" part.

Also, for doc changes, it is helpful to not rewrap the paragraphs. That helps reviewers see what changed and what didn't.

For module internal class references, we tend to use the full qualifier in only a handful of cases. The problem is that the full markup generates many unnecessary links to the same targets. This makes the text harder to read and less usable.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella csabella reopened this Oct 1, 2018
@csabella
Copy link
Contributor Author

csabella commented Oct 1, 2018

I have made the requested changes; please review again.

Sorry about making the extra changes to the links. It had looked like they had been originally intended to be links, but had broken at some point, which led me to try to fix them.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@rhettinger
Copy link
Contributor

Close and reopen to retrigger the Appveyor bot which was stuck for some reason.

@rhettinger rhettinger reopened this Oct 2, 2018
@rhettinger rhettinger merged commit 11c4eaa into python:master Oct 2, 2018
@csabella csabella deleted the recent branch October 2, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants